Arm backend: test without output re-order workaround #15826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default outputs are re-ordered to correct order during TOSA lowering. However this is seen as a workaround as it should not be needed. Furthermore the output issue is not easily reproduced, rather it seems to happen randomly. Therefore we add a test case without the workaround, which is currently passing. In case it won't pass without the workaround at some point, the new changes might give some hints on why the workaround is needed and how to fix it. In case it continues to pass, we may switch the default and potentially even remove the workaround. Change-Id: I4c65cfaebe0a662d43c339c64a370b308674d1b5
mansnils
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15826
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit fe878a4 with merge base 3374ff8 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
|
Timeout problem trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (push)Cancelled after 121m |
Collaborator
|
Seem to be happening after #14109 was merged, trying to revert that PR |
Collaborator
Author
|
See comment for more context of workaround: #13454 (comment) |
zingo
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default outputs are re-ordered to correct order during TOSA lowering. However this is seen as a workaround as it should not be needed. Furthermore the output issue is not easily reproduced, rather it seems to happen randomly. Therefore we add a test case without the workaround, which is currently passing.
In case it won't pass without the workaround at some point, the new changes might give some hints on why the workaround is needed and how to fix it.
In case it continues to pass, we may switch the default and potentially even remove the workaround.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai